Skip to content

ServiceInfo model improvements and deprecations#1311

Merged
balloob merged 5 commits intomasterfrom
epenet-patch-2
May 3, 2022
Merged

ServiceInfo model improvements and deprecations#1311
balloob merged 5 commits intomasterfrom
epenet-patch-2

Conversation

@epenet
Copy link
Copy Markdown
Contributor

@epenet epenet commented Apr 28, 2022

Proposed change

Add blog post for home-assistant/core#60540

Type of change

  • Document existing features within Home Assistant
  • Document new or changing features which there is an existing pull request elsewhere
  • Spelling or grammatical corrections, or rewording for improved clarity
  • Changes to the backend of this documentation
  • Removed stale or deprecated documentation

Additional information

@epenet epenet mentioned this pull request Apr 28, 2022
Merged
22 tasks
frenck
frenck reviewed Apr 28, 2022
View reviewed changes
@epenet @frenck
Update blog/2022-04-28-serviceinfo-model-improvements.md
75dba7b 
Co-authored-by: Franck Nijhof <git@frenck.dev>
epenet
epenet commented Apr 28, 2022
View reviewed changes
epenet
epenet commented Apr 28, 2022
View reviewed changes
frenck and others added 3 commits April 28, 2022 14:15
@frenck @epenet
Update blog/2022-04-28-serviceinfo-model-improvements.md
58e7818 
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@frenck @epenet
Update blog/2022-04-28-serviceinfo-model-improvements.md
4bb40b1 
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@balloob
Rename 2022-04-28-serviceinfo-model-improvements.md to 2022-05-03-ser…
71fed91 
…viceinfo-model-improvements.md
@balloob balloob merged commit 4ff6bfa into master May 3, 2022
@balloob balloob deleted the epenet-patch-2 branch May 3, 2022 16:37
MartinHjelmare
MartinHjelmare reviewed May 4, 2022
View reviewed changes
blog/2022-05-03-serviceinfo-model-improvements.md
As of Home Assistant Core 2022.6, access to discovery information via the, previously deprecated, dictionary methods have been removed.


This applies to the `DhcpServiceInfo`, `MqttServiceInfo`, `SsdpServiceInfo`, `UsbServiceInfo`, and `ZeroconfServiceInfo` instances.
Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please link to the relevant dev docs page.

Copy link
Copy Markdown
Contributor Author

@epenet epenet May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are these the best location to link?
https://developers.home-assistant.io/docs/creating_integration_manifest/#dhcp
https://developers.home-assistant.io/docs/creating_integration_manifest/#mqtt
https://developers.home-assistant.io/docs/creating_integration_manifest/#ssdp
https://developers.home-assistant.io/docs/creating_integration_manifest/#usb
https://developers.home-assistant.io/docs/creating_integration_manifest/#zeroconf

Copy link
Copy Markdown
Member

@MartinHjelmare MartinHjelmare May 4, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add a paragraph with some text and example of a discovery step in the config flow docs?

https://developers.home-assistant.io/docs/config_entries_config_flow_handler#discovery-steps

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@frenck frenck frenck left review comments

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@balloob balloob balloob approved these changes

Assignees

No one assigned

Labels

cla-signed

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@epenet @frenck @balloob @MartinHjelmare @homeassistant